[webkit-reviews] review granted: [Bug 209210] Default attachment icon is not necessarily the same as the file attachment icon whose extension is ".dat" : [Attachment 393813] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 17 19:52:56 PDT 2020


Daniel Bates <dbates at webkit.org> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 209210: Default attachment icon is not necessarily the same as the file
attachment icon whose extension is ".dat"
https://bugs.webkit.org/show_bug.cgi?id=209210

Attachment 393813: Patch

https://bugs.webkit.org/attachment.cgi?id=393813&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 393813
  --> https://bugs.webkit.org/attachment.cgi?id=393813
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393813&action=review

This patch looks good.

> LayoutTests/ChangeLog:9
> +	   returns for âpublic.dataâ icon.

Ok as-is. No change needed. There are some fancy quotes here.


More information about the webkit-reviews mailing list