[webkit-reviews] review granted: [Bug 209208] Remove unneeded and incorrect respondsToSelector check. : [Attachment 393807] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 17 18:55:01 PDT 2020
Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 209208: Remove unneeded and incorrect respondsToSelector check.
https://bugs.webkit.org/show_bug.cgi?id=209208
Attachment 393807: Patch
https://bugs.webkit.org/attachment.cgi?id=393807&action=review
--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 393807
--> https://bugs.webkit.org/attachment.cgi?id=393807
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=393807&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8703
> return NO;
You should remove this extra return NO.
Also, there's another similar respondsToSelector check nearby that can be
removed
More information about the webkit-reviews
mailing list