[webkit-reviews] review granted: [Bug 209007] SharedMemory::Handle::m_size should be more consistent : [Attachment 393796] Patch v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 17 15:44:55 PDT 2020
Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 209007: SharedMemory::Handle::m_size should be more consistent
https://bugs.webkit.org/show_bug.cgi?id=209007
Attachment 393796: Patch v3
https://bugs.webkit.org/attachment.cgi?id=393796&action=review
--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 393796
--> https://bugs.webkit.org/attachment.cgi?id=393796
Patch v3
View in context: https://bugs.webkit.org/attachment.cgi?id=393796&action=review
> Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp:197
> + RELEASE_ASSERT(round_page(handle.m_size) == handle.m_size);
Not sure I understand why we need this to be RELEASE_ASSERT.
More information about the webkit-reviews
mailing list