[webkit-reviews] review granted: [Bug 207307] REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing : [Attachment 393783] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 207307: REGRESSION: [ macOS wk1 ] ASSERTION FAILED:
_notifications.contains(notificationID)
imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky
crashing
https://bugs.webkit.org/show_bug.cgi?id=207307

Attachment 393783: Patch

https://bugs.webkit.org/attachment.cgi?id=393783&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 393783
  --> https://bugs.webkit.org/attachment.cgi?id=393783
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393783&action=review

> Tools/DumpRenderTree/mac/MockWebNotificationProvider.mm:147
> +	   auto notification =
_notifications.take(_notifications.begin()->key);

This unnecessarily rehashes a lot.  Why don't we just iterate then clear?