[webkit-reviews] review granted: [Bug 209094] TextTrackBase should validate language before setting m_validBCP47Language : [Attachment 393762] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 209094: TextTrackBase should validate language before setting
m_validBCP47Language
https://bugs.webkit.org/show_bug.cgi?id=209094

Attachment 393762: Patch

https://bugs.webkit.org/attachment.cgi?id=393762&action=review




--- Comment #5 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 393762
  --> https://bugs.webkit.org/attachment.cgi?id=393762
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393762&action=review

> Source/WebCore/testing/Internals.cpp:3776
> +    return String { track.validBCP47Language() };

nit: this could be:

return track.validBCP47Language().string();