[webkit-reviews] review granted: [Bug 205658] [GTK][WPE] Migrate to Flatpak-based dev SDK : [Attachment 393236] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 17 09:17:17 PDT 2020


Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 205658: [GTK][WPE] Migrate to Flatpak-based dev SDK
https://bugs.webkit.org/show_bug.cgi?id=205658

Attachment 393236: Patch

https://bugs.webkit.org/attachment.cgi?id=393236&action=review




--- Comment #98 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 393236
  --> https://bugs.webkit.org/attachment.cgi?id=393236
Patch

r=me
I set cq- because this patch changes the default method for handling
third-party libraries and can cause big surprise to developers.
So I think we should send a mail to webkit-dev (or both gtk-dev+wpe-dev)
webkit.org mailing lists telling about this before landing it (and at the same
time encouraging everyone to test it and report any issue found with it)
Its also a good idea telling that Ubuntu LTS users can find the required
flatpak version on that ppa, and debian stable users have the required version
on the backports repository.
Thanks for all!


More information about the webkit-reviews mailing list