[webkit-reviews] review granted: [Bug 209158] AccessCase::canReplace should allow a Getter to replace an IntrinsicGetter : [Attachment 393707] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 16 23:53:24 PDT 2020
Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 209158: AccessCase::canReplace should allow a Getter to replace an
IntrinsicGetter
https://bugs.webkit.org/show_bug.cgi?id=209158
Attachment 393707: Patch
https://bugs.webkit.org/attachment.cgi?id=393707&action=review
--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 393707
--> https://bugs.webkit.org/attachment.cgi?id=393707
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=393707&action=review
r=me
> Source/JavaScriptCore/ChangeLog:9
> + When we override an intrinsic getter with an user defined getter, we
might end up with the
"an user" => "a user"
> Source/JavaScriptCore/bytecode/AccessCase.cpp:680
> + case Getter:
You're missing the other direction here, where |this| is InrinsicGetter, and
the other is Getter
If you wanted to be fancy, you could have something like:
bool isInterchangeable(AccessType a, AccessType b)
{
if (a == b)
return true;
if (a == Getter and b == IntrinsicGetter)
return true;
if (a == IntrinsicGettter and b == Getter)
return true
}
and then just write this function in terms of that
More information about the webkit-reviews
mailing list