[webkit-reviews] review denied: [Bug 208603] REGRESSION(r257759): Web Inspector: Settings icon sometimes placed below the tab bar : [Attachment 393199] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 208603: REGRESSION(r257759): Web Inspector: Settings icon sometimes placed
below the tab bar
https://bugs.webkit.org/show_bug.cgi?id=208603

Attachment 393199: Patch

https://bugs.webkit.org/attachment.cgi?id=393199&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 393199
  --> https://bugs.webkit.org/attachment.cgi?id=393199
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393199&action=review

r-, for reason described in TabBar.js

> Source/WebInspectorUI/UserInterface/Views/TabBar.js:468
> +		   availableSpace -= measureItemWidth(tabBarItem);

We don't want to do this here because `WI.PinnedTabBarItem` is considered in
`recalculateItemWidths()`, meaning that we will double count it's width.

Please see my comment in <https://webkit.org/b/204627#c56>.