[webkit-reviews] review granted: [Bug 208998] JavaScript identifier grammar supports unescaped astral symbols, but JSC doesn’t : [Attachment 393695] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 208998: JavaScript identifier grammar supports unescaped astral symbols,
but JSC doesn’t
https://bugs.webkit.org/show_bug.cgi?id=208998

Attachment 393695: Patch

https://bugs.webkit.org/attachment.cgi?id=393695&action=review




--- Comment #9 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 393695
  --> https://bugs.webkit.org/attachment.cgi?id=393695
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393695&action=review

r=me

> Source/JavaScriptCore/parser/Lexer.cpp:2625
> +    // FIXME: This should probably not be a lex error but dealing with
surrogate pairs here is annoying and it's going to be an error anyway...

Add a bug for this FIXME.