[webkit-reviews] review requested: [Bug 209146] Fix many warnings with Clang 7.0 on GTK x86-64 in Debug. : [Attachment 393683] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 16 14:32:32 PDT 2020
Charlie Turner <cturner at igalia.com> has asked for review:
Bug 209146: Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
https://bugs.webkit.org/show_bug.cgi?id=209146
Attachment 393683: Patch
https://bugs.webkit.org/attachment.cgi?id=393683&action=review
--- Comment #3 from Charlie Turner <cturner at igalia.com> ---
Created attachment 393683
--> https://bugs.webkit.org/attachment.cgi?id=393683&action=review
Patch
Now it becomes visible why there were several seemingly unused this captures in
lambdas, the RELEASE_LOG macros implicity depend on this for the class-local
logger() method to resovllve. When
https://bugs.webkit.org/show_bug.cgi?id=195182 lands these logging macros will
become less of a maintenance burden for non-Cocoa ports. .
More information about the webkit-reviews
mailing list