[webkit-reviews] review denied: [Bug 209133] AuthenticatorResponseData::decode should check bufferIsLargeEnoughToContain before allocating buffers : [Attachment 393637] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has denied  review:
Bug 209133: AuthenticatorResponseData::decode should check
bufferIsLargeEnoughToContain before allocating buffers
https://bugs.webkit.org/show_bug.cgi?id=209133

Attachment 393637: Patch

https://bugs.webkit.org/attachment.cgi?id=393637&action=review




--- Comment #3 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 393637
  --> https://bugs.webkit.org/attachment.cgi?id=393637
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393637&action=review

Please fix all build failures.

> Source/WebCore/Modules/webauthn/AuthenticatorResponseData.h:114
> +    if (!decoder.template
bufferIsLargeEnoughToContain<uint8_t>(rawIdLength))

This doesn't seem to be a valid C++ expression.

> Source/WebCore/Modules/webauthn/AuthenticatorResponseData.h:134
> +	   if (!decoder.template
bufferIsLargeEnoughToContain<uint8_t>(attestationObjectLength))

This doesn't seem to be a valid C++ expression.

> Source/WebCore/Modules/webauthn/AuthenticatorResponseData.h:150
> +    if (!decoder.template
bufferIsLargeEnoughToContain<uint8_t>(authenticatorDataLength))

This doesn't seem to be a valid C++ expression.

> Source/WebCore/Modules/webauthn/AuthenticatorResponseData.h:163
> +    if (!decoder.template
bufferIsLargeEnoughToContain<uint8_t>(signatureLength))

This doesn't seem to be a valid C++ expression.

> Source/WebCore/Modules/webauthn/AuthenticatorResponseData.h:189
> +    if (!decoder.template
bufferIsLargeEnoughToContain<uint8_t>(userHandleLength))

This doesn't seem to be a valid C++ expression.