[webkit-reviews] review granted: [Bug 209086] Color Picker crashes on touch : [Attachment 393662] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 209086: Color Picker crashes on touch
https://bugs.webkit.org/show_bug.cgi?id=209086

Attachment 393662: Patch

https://bugs.webkit.org/attachment.cgi?id=393662&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 393662
  --> https://bugs.webkit.org/attachment.cgi?id=393662
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393662&action=review

> LayoutTests/fast/forms/color/color-input-activate-crash.html:13
> +		if (!testRunner.runUIScript)

Nit - spaces instead of tabs.

> LayoutTests/fast/forms/color/color-input-activate-crash.html:16
> +	    var input = document.getElementById('colorInput');

Nit - it looks like there are a mix of spaces and tabs here.

> LayoutTests/fast/forms/color/color-input-activate-crash.html:19
> +		await UIHelper.activateElementAndWaitForInputSession(input);
> +	    document.getElementById('result').innerHTML = 'PASS: Test did not
crash';
> +	    testRunner.notifyDone();

Ditto with these lines.

> LayoutTests/fast/forms/color/color-input-activate-crash.html:22
> +	window.addEventListener('load', runTest, false);

Ditto.