[webkit-reviews] review denied: [Bug 209126] Simplify the mechanism to paint captions in video fullscreen and picture-in-picture : [Attachment 393621] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 16 09:42:52 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 209126: Simplify the mechanism to paint captions in video fullscreen and
picture-in-picture
https://bugs.webkit.org/show_bug.cgi?id=209126

Attachment 393621: Patch

https://bugs.webkit.org/attachment.cgi?id=393621&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 393621
  --> https://bugs.webkit.org/attachment.cgi?id=393621
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393621&action=review

Seems OK but let's see another patch.

> Source/WebCore/page/Page.cpp:1367
>  #if ENABLE(VIDEO_TRACK)

This shouldn't be inside the #ifdef any more.


More information about the webkit-reviews mailing list