[webkit-reviews] review granted: [Bug 207324] KeyedDecoderGeneric fails to allocate Vector while decoding broken data : [Attachment 393626] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 207324: KeyedDecoderGeneric fails to allocate Vector while decoding broken
data
https://bugs.webkit.org/show_bug.cgi?id=207324

Attachment 393626: Patch

https://bugs.webkit.org/attachment.cgi?id=393626&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 393626
  --> https://bugs.webkit.org/attachment.cgi?id=393626
Patch

I see the same mistake in:

1) decodeCFData in CertificateInfo.h
2) AuthenticatorResponseData::decode where it also uses ArrayBuffer::create but
should be using ArrayBuffer::tryCreate
3) SerializedScriptValue::decode
4) decodeSharedBuffer and decodeTypesAndData in WebCoreArgumentCoders.cpp

We need someone to fix all of those. May not be as easy to write tests for
those.