[webkit-reviews] review granted: [Bug 209117] Add missing checks needed for AppBound Quirk : [Attachment 393595] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 209117: Add missing checks needed for AppBound Quirk
https://bugs.webkit.org/show_bug.cgi?id=209117

Attachment 393595: Patch

https://bugs.webkit.org/attachment.cgi?id=393595&action=review




--- Comment #3 from John Wilander <wilander at apple.com> ---
Comment on attachment 393595
  --> https://bugs.webkit.org/attachment.cgi?id=393595
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393595&action=review

r=me with comments.

> Source/WebKit/ChangeLog:8
> +

Did you mean to put the same description here as in the WebCore change log?

> Source/WebCore/loader/FrameLoaderClient.h:383
> +    virtual bool needsInAppBrowserPrivacyQuirks() { return false; }

Is there a reason for not making this const?

> Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:292
> +    bool needsInAppBrowserPrivacyQuirks() final;

This too could be const.