[webkit-reviews] review granted: [Bug 209063] Gather PDF scripts to run on a background thread : [Attachment 393590] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 14 13:55:49 PDT 2020


Geoffrey Garen <ggaren at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 209063: Gather PDF scripts to run on a background thread
https://bugs.webkit.org/show_bug.cgi?id=209063

Attachment 393590: Patch

https://bugs.webkit.org/attachment.cgi?id=393590&action=review




--- Comment #13 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 393590
  --> https://bugs.webkit.org/attachment.cgi?id=393590
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393590&action=review

r=me

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1564
> +    ASSERT(m_documentFinishedLoading);

I think this assert is no longer valid?


More information about the webkit-reviews mailing list