[webkit-reviews] review granted: [Bug 208952] [CMake] Warning when ccache is not installed : [Attachment 393301] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 208952: [CMake] Warning when ccache is not installed
https://bugs.webkit.org/show_bug.cgi?id=208952

Attachment 393301: Patch

https://bugs.webkit.org/attachment.cgi?id=393301&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 393301
  --> https://bugs.webkit.org/attachment.cgi?id=393301
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393301&action=review

> ChangeLog:10
> +	   Change the warning when ccache is not installed to a status message.
We shouldn't be

Same things as in bug 208970, comment 3, Again patch is OK as-is. NO CHANGE
NEEDED.

[[
This is ok as-is. No change is needed. The optimal ChangeLog would move all the
text in this line and later ABOVE the file name so as to be the description of
the change because:

1. There is only one file changed in this patch so there's no need for per file
comments.

2. Per file/function comments should be concise, no longer than a single
paragraph. They are meant to provide more fine grain descriptions of the
charges in the patch.
]]