[webkit-reviews] review granted: [Bug 209100] [Tree building] Reset the fragmented flow status before signal will-be-removed. : [Attachment 393571] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 13 20:54:39 PDT 2020
Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 209100: [Tree building] Reset the fragmented flow status before signal
will-be-removed.
https://bugs.webkit.org/show_bug.cgi?id=209100
Attachment 393571: Patch
https://bugs.webkit.org/attachment.cgi?id=393571&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 393571
--> https://bugs.webkit.org/attachment.cgi?id=393571
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=393571&action=review
> Source/WebCore/ChangeLog:3
> + [Tree building] Reset the fragmented flow status before signal
will-be-removed.
Maybe "before calling child.willBeRemovedFromTree()"
> Source/WebCore/ChangeLog:9
> + ::willBeRemoved() assumes all the cleanup has happened and it's the
final step before calling d'tor.
It this referring to the child.willBeRemovedFromTree()?
More information about the webkit-reviews
mailing list