[webkit-reviews] review granted: [Bug 209097] Fix the "deliver cached ranges" logic in PDFPlugin (and other small cleanups) : [Attachment 393561] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 209097: Fix the "deliver cached ranges" logic in PDFPlugin (and other small
cleanups)
https://bugs.webkit.org/show_bug.cgi?id=209097

Attachment 393561: Patch

https://bugs.webkit.org/attachment.cgi?id=393561&action=review




--- Comment #3 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 393561
  --> https://bugs.webkit.org/attachment.cgi?id=393561
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393561&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1441
> +    if ([m_pdfDocument.get()
respondsToSelector:NSSelectorFromString(@"setHasHighLatencyDataProvider:")])
> +	   [m_pdfDocument.get() setHasHighLatencyDataProvider:NO];

You might need to forward declare this to call it like this. Otherwise you will
need to do an objc_msgSend or performSelector:. If you forward declare, you can
just do @selector(setHasHighLatencyDataProvider:) instead of
NSSelectorFromString.