[webkit-reviews] review granted: [Bug 209011] WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations : [Attachment 393506] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 209011: WKWebView._negotiatedLegacyTLS should be correct after back/forward
navigations
https://bugs.webkit.org/show_bug.cgi?id=209011

Attachment 393506: Patch

https://bugs.webkit.org/attachment.cgi?id=393506&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 393506
  --> https://bugs.webkit.org/attachment.cgi?id=393506
Patch

lgtm
As of setSource, it does not look great to have it in two places. I would leave
that for a future refactoring that would add a platform independent redirection
handler in NetworkDataTask so that setSource is no longer called in
NetworkLoad.
Also, I am not sure NetworkTask is the right place. Source is only useful for
WebProcess so this seems more a NetworkResourceLoader thing