[webkit-reviews] review granted: [Bug 209032] Report all third party loads on a per-page basis : [Attachment 393494] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 209032: Report all third party loads on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=209032

Attachment 393494: Patch

https://bugs.webkit.org/attachment.cgi?id=393494&action=review




--- Comment #16 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 393494
  --> https://bugs.webkit.org/attachment.cgi?id=393494
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393494&action=review

> Source/WebCore/Modules/websockets/WebSocket.cpp:331
> +	      
frame->loader().client().addLoadedThirdPartyDomain(WTFMove(domain));

You're calling addLoadedThirdPartyDomain() with a domain that is not
necessarily third-party. As a result, I think this method is badly named. Maybe
something like FrameLoaderClient::didLoadFromRegistrableDomain(), very generic
and then it is up to the client implementation to decide what to do with it.