[webkit-reviews] review granted: [Bug 209054] Remove AffectedByDrag style flag : [Attachment 393490] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 209054: Remove AffectedByDrag style flag
https://bugs.webkit.org/show_bug.cgi?id=209054

Attachment 393490: patch

https://bugs.webkit.org/attachment.cgi?id=393490&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 393490
  --> https://bugs.webkit.org/attachment.cgi?id=393490
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393490&action=review

Dragging is under tested, so some manual testing of this is warranted.

> Source/WebCore/dom/Element.h:318
> +    bool isDragged() const { return isUserActionElement() &&
isUserActionElementDragged(); }

isDragged is weird. isBeingDragged?

> Source/WebCore/dom/Element.h:324
> +    void setDragged(bool);

setIsBeingDragged?

> Source/WebCore/dom/Node.h:612
> +	   ChildrenAffectedByForwardPositionalRules = 1 << 1,
> +	   DescendantsAffectedByForwardPositionalRules = 1 << 2,
> +	   ChildrenAffectedByBackwardPositionalRules = 1 << 3,
> +	   DescendantsAffectedByBackwardPositionalRules = 1 << 4,
> +	   ChildrenAffectedByPropertyBasedBackwardPositionalRules = 1 << 5,

I would align the = but that's just me.