[webkit-reviews] review granted: [Bug 209031] Correct preference handling and naming conventions in AppBound browsing preferences : [Attachment 393436] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 209031: Correct preference handling and naming conventions in AppBound
browsing preferences
https://bugs.webkit.org/show_bug.cgi?id=209031

Attachment 393436: Patch

https://bugs.webkit.org/attachment.cgi?id=393436&action=review




--- Comment #4 from John Wilander <wilander at apple.com> ---
Comment on attachment 393436
  --> https://bugs.webkit.org/attachment.cgi?id=393436
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393436&action=review

> Source/WebKit/ChangeLog:10
> +	   and the quirk flag, which led to some code not executing when
expected.

Would be nice with a link to the revision or bug where the mistake was made.

> Source/WebKit/ChangeLog:15
> +	      'WebKitDebug', not 'WebKitInternal' or 'WebKitInternalDebug'.

I don’t know these by heart so I trust you made doubly sure this time. :)