[webkit-reviews] review granted: [Bug 208824] WebKit uses Alphabetic Baseline when "-webkit-text-orientation" is "mixed" in Vertical Writing Mode : [Attachment 393420] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted guowei_yang at apple.com's
request for review:
Bug 208824: WebKit uses Alphabetic Baseline when "-webkit-text-orientation" is
"mixed" in Vertical Writing Mode
https://bugs.webkit.org/show_bug.cgi?id=208824

Attachment 393420: Patch

https://bugs.webkit.org/attachment.cgi?id=393420&action=review




--- Comment #19 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 393420
  --> https://bugs.webkit.org/attachment.cgi?id=393420
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393420&action=review

This looks good.

>
LayoutTests/editing/selection/vertical-rl-rtl-extend-line-forward-br-mixed.html
:9
> +<div id="test" style="font-family: monospace; font-size: 20px; height: 15ex;
-webkit-writing-mode: vertical-rl; -webkit-text-orientation: mixed; outline:
none;" contenteditable>

It's kind of surprising that you made a new test with the same content as the
old test, and then modified the old test, instead of not modifying the old test
and adding a new one with the modifications .... but I guess it's fine. Not
really worth changing at this point, but just surprising.