[webkit-reviews] review granted: [Bug 209026] [iOS WK2] Some pointerevents tests time out : [Attachment 393427] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 12 16:55:31 PDT 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 209026: [iOS WK2] Some pointerevents tests time out
https://bugs.webkit.org/show_bug.cgi?id=209026

Attachment 393427: Patch

https://bugs.webkit.org/attachment.cgi?id=393427&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 393427
  --> https://bugs.webkit.org/attachment.cgi?id=393427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393427&action=review

> LayoutTests/pointerevents/utils.js:146
>	       setTimeout(resolve, durationInSeconds * 1000)

Not for this patch, but it looks like we should fix this to actually listen for
the zooming UIScriptController callbacks to know when the zooming animation is
done instead of having a hard-coded timeout.

> LayoutTests/pointerevents/utils.js:231
> +	   console.log(script);

Was this console.log intended?


More information about the webkit-reviews mailing list