[webkit-reviews] review granted: [Bug 208940] Add API endpoint in EWS django app to provide patch status in json format : [Attachment 393419] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 12 16:23:01 PDT 2020


Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 208940: Add API endpoint in EWS django app to provide patch status in json
format
https://bugs.webkit.org/show_bug.cgi?id=208940

Attachment 393419: Patch

https://bugs.webkit.org/attachment.cgi?id=393419&action=review




--- Comment #6 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 393419
  --> https://bugs.webkit.org/attachment.cgi?id=393419
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393419&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/status.py:67
> +	   response_data = {'status': self._build_statuses_for_patch(patch)}

I think we should return the list directly instead of packaging it in a
dictionary.


More information about the webkit-reviews mailing list