[webkit-reviews] review granted: [Bug 209010] Cache the ScrollView platformWidget to avoid [WebAccessibilityObjectWrapper scrollViewParent] hitting the main thread too often. : [Attachment 393402] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 12 13:10:30 PDT 2020
chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 209010: Cache the ScrollView platformWidget to avoid
[WebAccessibilityObjectWrapper scrollViewParent] hitting the main thread too
often.
https://bugs.webkit.org/show_bug.cgi?id=209010
Attachment 393402: Patch
https://bugs.webkit.org/attachment.cgi?id=393402&action=review
--- Comment #2 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 393402
--> https://bugs.webkit.org/attachment.cgi?id=393402
Patch
this looks like it will work. holding onto a NSView off the main thread
shouldn't be problematic in and of itself. however, if AppKit makes ax calls on
that object outside of WebKit it might require a change in AppKit
More information about the webkit-reviews
mailing list