[webkit-reviews] review granted: [Bug 209000] Resource load statistics data summary should return all third party data : [Attachment 393383] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 12 10:33:38 PDT 2020
John Wilander <wilander at apple.com> has granted katherine_cheney at apple.com's
request for review:
Bug 209000: Resource load statistics data summary should return all third party
data
https://bugs.webkit.org/show_bug.cgi?id=209000
Attachment 393383: Patch
https://bugs.webkit.org/attachment.cgi?id=393383&action=review
--- Comment #3 from John Wilander <wilander at apple.com> ---
Comment on attachment 393383
--> https://bugs.webkit.org/attachment.cgi?id=393383
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=393383&action=review
r=me. Please address my comment on the cookie blocking mode.
>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:844
> + || sortedStatistics.bindText(1, "%")
I think this should be made conditional on the configured
WebCore::ThirdPartyCookieBlockingMode. If ==
WebCore::ThirdPartyCookieBlockingMode::All, send back all third party data,
otherwise keep the old behavior. You already have a
thirdPartyCookieBlockingMode() getter in the ResourceLoadStatisticsStore base
class. Then your API tests might have to enable
WebCore::ThirdPartyCookieBlockingMode::All if they aren't already running under
that configuration.
> Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:986
> + // Set two third parties to be prevalent, leave evil1.com as
non-prevalent to ensure
Personally, I'd prefer not to call prevalent domains "evil" since there's
nothing inherently evil about them. But I know it's existing code.
More information about the webkit-reviews
mailing list