[webkit-reviews] review granted: [Bug 208918] FrameLoader should own its FrameLoaderClient : [Attachment 393363] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 208918: FrameLoader should own its FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=208918

Attachment 393363: Patch

https://bugs.webkit.org/attachment.cgi?id=393363&action=review




--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 393363
  --> https://bugs.webkit.org/attachment.cgi?id=393363
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393363&action=review

r=me

> Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:-175
> -void WebFrameLoaderClient::frameLoaderDestroyed()
> -{
> -    m_frame->invalidate();
> -
> -    // Balances explicit ref() in WebFrame::create().
> -    m_frame->deref();
> -}

It is a joy to see code like this disappear ��