[webkit-reviews] review denied: [Bug 207648] [GTK] Add EWS testers to run GTK layout tests : [Attachment 393283] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Diego Pino
<dpino at igalia.com>'s request for review:
Bug 207648: [GTK] Add EWS testers to run GTK layout tests
https://bugs.webkit.org/show_bug.cgi?id=207648

Attachment 393283: Patch

https://bugs.webkit.org/attachment.cgi?id=393283&action=review




--- Comment #19 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 393283
  --> https://bugs.webkit.org/attachment.cgi?id=393283
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393283&action=review

> Tools/BuildSlaveSupport/ews-build/config.json:368
> +    {
> +	 "name": "GTK-WK2-Tests-EWS",
> +	 "shortname": "gtk-wk2",
> +	 "icon": "testOnly",
> +	 "factory": "GTKTestsFactory",
> +	 "platform": "gtk",
> +	 "configuration": "release",
> +	 "architectures": ["x86_64"],
> +	 "triggers": ["gtk-webkit2-tests-ews"],

This is wrong.
You need to set triggers in the queue named "GTK-Build-EWS".
Look for example the queue named "macOS-Mojave-Release-Build-EWS" how it
triggers "triggers": ["api-tests-mac-ews",
"macos-mojave-release-wk1-tests-ews", "macos-mojave-release-wk2-tests-ews"],
In our case the queue ""GTK-Build-EWS" needs to trigger "GTK-WK2-Tests-EWS" and
"API-Tests-GTK-EWS"