[webkit-reviews] review denied: [Bug 208904] Safari sometimes crashes when switch video into PiP mode : [Attachment 393338] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has denied Peng Liu <peng.liu6 at apple.com>'s request for
review:
Bug 208904: Safari sometimes crashes when switch video into PiP mode
https://bugs.webkit.org/show_bug.cgi?id=208904

Attachment 393338: Patch

https://bugs.webkit.org/attachment.cgi?id=393338&action=review




--- Comment #11 from zalan <zalan at apple.com> ---
Comment on attachment 393338
  --> https://bugs.webkit.org/attachment.cgi?id=393338
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393338&action=review

>> Source/WebCore/rendering/RenderMediaControlElements.cpp:107
>> +   
static_cast<MediaControlTextTrackContainerElement*>(element())->layoutIfNeeded(
);
> 
> Elements don't do layout.

I am sure we can do better than static_cast<>->layout().