[webkit-reviews] review granted: [Bug 208965] [GPUP] Add entry points for non-Cocoa ports : [Attachment 393325] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 11 19:04:00 PDT 2020


Michael Catanzaro <mcatanzaro at gnome.org> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 208965: [GPUP] Add entry points for non-Cocoa ports
https://bugs.webkit.org/show_bug.cgi?id=208965

Attachment 393325: Patch

https://bugs.webkit.org/attachment.cgi?id=393325&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 393325
  --> https://bugs.webkit.org/attachment.cgi?id=393325
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393325&action=review

Entry points are better than no entry points!

> Source/WebKit/GPUProcess/EntryPoint/win/GPUProcessMain.cpp:30
> +#include <stdio.h>
> +#include <windows.h>

Surely you don't need these.


More information about the webkit-reviews mailing list