[webkit-reviews] review granted: [Bug 208953] [macOS] _AXSApplicationAccessibilityEnabled should not be called : [Attachment 393302] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 208953: [macOS] _AXSApplicationAccessibilityEnabled should not be called
https://bugs.webkit.org/show_bug.cgi?id=208953

Attachment 393302: Patch

https://bugs.webkit.org/attachment.cgi?id=393302&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 393302
  --> https://bugs.webkit.org/attachment.cgi?id=393302
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393302&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:459
> +    if (_AXSApplicationAccessibilityEnabled())

So we still want to pass the cfprefsd extension on macOS without checking this
call?

> Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:213
> +#if PLATFORM(IOS_FAMILY)

Does this call work on MacCatalyst? Maybe this should exclude MacCatalyst
builds?