[webkit-reviews] review granted: [Bug 208951] Adopt AVSampleBufferVideoOutput : [Attachment 393298] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 11 16:03:10 PDT 2020
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 208951: Adopt AVSampleBufferVideoOutput
https://bugs.webkit.org/show_bug.cgi?id=208951
Attachment 393298: Patch
https://bugs.webkit.org/attachment.cgi?id=393298&action=review
--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 393298
--> https://bugs.webkit.org/attachment.cgi?id=393298
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=393298&action=review
>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourc
eAVFObjC.mm:772
> + m_videoOutput =
adoptNS([PAL::allocAVSampleBufferVideoOutputInstance() init]);
Nit: it might be worth adding an ASSERT here
More information about the webkit-reviews
mailing list