[webkit-reviews] review granted: [Bug 208945] [macOS] Crash under WebKit::WebProcessPool::platformInitialize() : [Attachment 393287] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 208945: [macOS] Crash under WebKit::WebProcessPool::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=208945

Attachment 393287: Patch

https://bugs.webkit.org/attachment.cgi?id=393287&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 393287
  --> https://bugs.webkit.org/attachment.cgi?id=393287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393287&action=review

r=me

> Source/WTF/wtf/cocoa/SoftLinking.h:53
> +}

I am shocked this doesn't already exist -- but it doesn't!

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:702
> +	   [[NSNotificationCenter defaultCenter]
removeObserver:m_accessibilityEnabledObserver.get()];

Isn't it okay to remove nil objects? I can't remember (though of course, some
containers blow up if you use nil things so maybe this is one of those cases).