[webkit-reviews] review canceled: [Bug 113849] [Cairo][SVG] marker-mid isn't shown on a joint of rectilinearly connected line-to path segments : [Attachment 393240] Updated patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has canceled Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 113849: [Cairo][SVG] marker-mid isn't shown on a joint of rectilinearly
connected line-to path segments
https://bugs.webkit.org/show_bug.cgi?id=113849

Attachment 393240: Updated patch

https://bugs.webkit.org/attachment.cgi?id=393240&action=review




--- Comment #25 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 393240
  --> https://bugs.webkit.org/attachment.cgi?id=393240
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393240&action=review

> LayoutTests/platform/gtk/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:18
> -    RenderSVGContainer {g} at (57,77) size 366x86
[transform={m=((1.00,0.00)(0.00,1.00)) t=(50.00,20.00)}] [start marker=marker1]
[middle marker=marker1] [end marker=marker1]
> -	 RenderSVGPath {path} at (57,77) size 86x86 [stroke={[type=SOLID]
[color=#000000]}] [fill={[type=SOLID] [color=#FFD700] [fill rule=EVEN-ODD]}]
[start marker=marker1] [middle marker=marker1] [end marker=marker1] [data="M 10
60 C 63.3333 60 90 86.6667 90 140 C 36.6667 140 10 113.333 10 60 Z M 10 140 C
10 86.6667 36.6667 60 90 60 C 90 113.333 63.3333 140 10 140 Z M 50 70 L 80 100
L 50 130 L 20 100 Z"]
> +    RenderSVGContainer {g} at (47,17) size 376x146
[transform={m=((1.00,0.00)(0.00,1.00)) t=(50.00,20.00)}] [start marker=marker1]
[middle marker=marker1] [end marker=marker1]
> +	 RenderSVGPath {path} at (47,17) size 96x146 [stroke={[type=SOLID]
[color=#000000]}] [fill={[type=SOLID] [color=#FFD700] [fill rule=EVEN-ODD]}]
[start marker=marker1] [middle marker=marker1] [end marker=marker1] [data="M 10
60 C 63.3333 60 90 86.6667 90 140 C 36.6667 140 10 113.333 10 60 Z M 10 140 C
10 86.6667 36.6667 60 90 60 C 90 113.333 63.3333 140 10 140 Z M 50 70 L 80 100
L 50 130 L 20 100 Z"]
>	 RenderSVGPath {polygon} at (147,77) size 86x86 [stroke={[type=SOLID]
[color=#000000]}] [fill={[type=SOLID] [color=#FFD700] [fill rule=EVEN-ODD]}]
[start marker=marker1] [middle marker=marker1] [end marker=marker1]
[points="100 60 120 140 140 60 160 140 180 60 180 100 100 100"]

Now that I see the pixel differences, it seems this tests is actually
regressing. I'll investigate.