[webkit-reviews] review granted: [Bug 208895] Introduce ResourceLoadStatisticsParameters and move members from NetworkSessionCreationParameters : [Attachment 393187] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 208895: Introduce ResourceLoadStatisticsParameters and move members from
NetworkSessionCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=208895

Attachment 393187: Patch

https://bugs.webkit.org/attachment.cgi?id=393187&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 393187
  --> https://bugs.webkit.org/attachment.cgi?id=393187
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393187&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1176
> +   
setResourceLoadStatisticsEnabled(parameters.resourceLoadStatisticsParameters.en
ableResourceLoadStatistics);

Since this is a NetworkSessionCreationParameters&&, we could move some of these
values, like m_resourceLoadStatisticsDirectory

> Source/WebKit/Shared/ResourceLoadStatisticsParameters.h:36
> +struct ResourceLoadStatisticsParameters {

Given we have ResourceLoadStatistics inside ResourceLoadStatisticsParameters,
could we remove ResourceLoadStatistics from the parameter names.
For instance s/resourceLoadStatisticsDirectory/directoy and
s/resourceLoadStatisticsDirectoryExtensionHandle/directoryExtensionHandle.