[webkit-reviews] review granted: [Bug 208899] [GPU Process] Work towards compiling out on non-Cocoa ports : [Attachment 393200] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 10 20:51:38 PDT 2020


Darin Adler <darin at apple.com> has granted Don Olmstead
<don.olmstead at sony.com>'s request for review:
Bug 208899: [GPU Process] Work towards compiling out on non-Cocoa ports
https://bugs.webkit.org/show_bug.cgi?id=208899

Attachment 393200: Patch

https://bugs.webkit.org/attachment.cgi?id=393200&action=review




--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 393200
  --> https://bugs.webkit.org/attachment.cgi?id=393200
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393200&action=review

>
Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:39
> +#include <WebCore/GraphicsContext.h>

I still think this include should be unconditional in the paragraph above
rather than having it inside an #else.


More information about the webkit-reviews mailing list