[webkit-reviews] review denied: [Bug 208893] Some common domains should always be App-bound domains : [Attachment 393191] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied katherine_cheney at apple.com's
request for review:
Bug 208893: Some common domains should always be App-bound domains
https://bugs.webkit.org/show_bug.cgi?id=208893

Attachment 393191: Patch

https://bugs.webkit.org/attachment.cgi?id=393191&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 393191
  --> https://bugs.webkit.org/attachment.cgi?id=393191
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393191&action=review

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:483
> +	   || startsWithLettersIgnoringASCIICase(domain.string(), "data:"));

I don't think this will work, because RegistrableDomains are just things like
"apple.com" or "webkit.org". I don't think we retain the protocol in the class.