[webkit-reviews] review granted: [Bug 208846] File upload cancels before files can be uploaded. : [Attachment 393117] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 208846: File upload cancels before files can be uploaded.
https://bugs.webkit.org/show_bug.cgi?id=208846

Attachment 393117: Patch

https://bugs.webkit.org/attachment.cgi?id=393117&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 393117
  --> https://bugs.webkit.org/attachment.cgi?id=393117
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393117&action=review

>> Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:473
>> +		[self _cancel];
> 
> Who cancels after the submenu is dismissed? If it's really necessary, it
seems like a problem that it doesn't happen.

Megan notes that the submenus themselves already call _cancel, so this should
be OK