[webkit-reviews] review granted: [Bug 208855] Make sure that ServiceWorkerFrameLoaderClient lifetime exceeds its frame lifetime : [Attachment 393134] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 208855: Make sure that ServiceWorkerFrameLoaderClient lifetime exceeds its
frame lifetime
https://bugs.webkit.org/show_bug.cgi?id=208855

Attachment 393134: Patch

https://bugs.webkit.org/attachment.cgi?id=393134&action=review




--- Comment #6 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 393134
  --> https://bugs.webkit.org/attachment.cgi?id=393134
Patch

r=me

Seems right to me that we should fix the bug and then change the design, so I
guess I'll say r+.

The ownership design for WebFrameLoaderClient seems busted and worth fixing,
though. I'd prefer a design where FrameLoader kept a unique_ptr to the client,
or, if that's not possible, then a RefPtr.