[webkit-reviews] review granted: [Bug 208689] [WPE] MiniBrowser: Close child WebViews when exiting : [Attachment 393119] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 208689: [WPE] MiniBrowser: Close child WebViews when exiting
https://bugs.webkit.org/show_bug.cgi?id=208689

Attachment 393119: Patch

https://bugs.webkit.org/attachment.cgi?id=393119&action=review




--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 393119
  --> https://bugs.webkit.org/attachment.cgi?id=393119
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393119&action=review

> Tools/MiniBrowser/wpe/main.cpp:154
> +    g_hash_table_remove(openViews, (gpointer*)webView);

This is cpp file, use C++ cast.

> Tools/MiniBrowser/wpe/main.cpp:174
> +    g_hash_table_add(openViews, (gpointer*)newWebView);

Ditto.

> Tools/MiniBrowser/wpe/main.cpp:303
> +    openViews = g_hash_table_new_full(NULL, NULL, g_object_unref, NULL);

And nullptr instead of NULL.