[webkit-reviews] review granted: [Bug 208823] WebKitTestRunner bundleID should not be cleared before every test : [Attachment 393056] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted katherine_cheney at apple.com's
request for review:
Bug 208823: WebKitTestRunner bundleID should not be cleared before every test
https://bugs.webkit.org/show_bug.cgi?id=208823

Attachment 393056: Patch

https://bugs.webkit.org/attachment.cgi?id=393056&action=review




--- Comment #5 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 393056
  --> https://bugs.webkit.org/attachment.cgi?id=393056
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393056&action=review

R=me.

>>> Tools/WebKitTestRunner/TestController.cpp:643
>>> +	     clearApplicationBundleIdentifierTestingOverride();
>> 
>> What happens with the next test if this is executed? Will it use the new
bundle id, or fall back to the one from Info.plist?
> 
> Every test will start out with the Info.plist bundle ID. It will only be
changed from that if a test manually sets the bundleID using TestOptions.

Sounds good!