[webkit-reviews] review granted: [Bug 208729] upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build : [Attachment 393058] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 208729: upload.py gets confused by git-svn checkouts, unable to upload test
results from my desk build
https://bugs.webkit.org/show_bug.cgi?id=208729

Attachment 393058: Patch

https://bugs.webkit.org/attachment.cgi?id=393058&action=review




--- Comment #9 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 393058
  --> https://bugs.webkit.org/attachment.cgi?id=393058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393058&action=review

> Tools/Scripts/webkitpy/port/base.py:1612
> +	       native_revision = scm.native_revision(path)

I don't think we need this outside of the if statement, should probably move it
to the used_revision assignment.

> Tools/Scripts/webkitpy/port/base.py:1619
> +	       native_branch = scm.native_branch(path)

Ditto.