[webkit-reviews] review granted: [Bug 208811] Generate commit-queue status bubble from new EWS : [Attachment 393033] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 208811: Generate commit-queue status bubble from new EWS
https://bugs.webkit.org/show_bug.cgi?id=208811

Attachment 393033: Patch

https://bugs.webkit.org/attachment.cgi?id=393033&action=review




--- Comment #5 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 393033
  --> https://bugs.webkit.org/attachment.cgi?id=393033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393033&action=review

>>> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:302
>>> +		 for queue in StatusBubble.ALL_QUEUES:
>> 
>> This part confuses me a bit because it seems to be the inverse of what we
had before.
>> 
>> Before, we would iterate through all bubbles if there was a patch and is had
NOT been sent to Buildbot, now, we iterate through all the bubble is there is a
patch and it HAS been sent to Buildbot.
> 
> Before, if a patch was not sent to buildbot, we would exit early and display
submit-to-ews button. If the patch was sent to buildbot, we would generate all
it's bubbles. Should be same now as well.

I'm sorry, you're right, was mis-reading the code.