[webkit-reviews] review granted: [Bug 208793] Revise In-App Browser Privacy checks to better reflect the meaning of the flag : [Attachment 393000] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 208793: Revise In-App Browser Privacy checks to better reflect the meaning
of the flag
https://bugs.webkit.org/show_bug.cgi?id=208793

Attachment 393000: Patch

https://bugs.webkit.org/attachment.cgi?id=393000&action=review




--- Comment #3 from John Wilander <wilander at apple.com> ---
Comment on attachment 393000
  --> https://bugs.webkit.org/attachment.cgi?id=393000
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393000&action=review

r=me with one comment.

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1219
> +	   if (m_isInAppBrowserPrivacyEnabled ||
NETWORK_SESSION_COCOA_ADDITIONS)

Is there a reason for doing this is two if clauses and not if
(isNavigatingToAppBoundDomain == NavigatingToAppBoundDomain::Yes &&
(m_isInAppBrowserPrivacyEnabled || NETWORK_SESSION_COCOA_ADDITIONS)) ? You do
write a single if clause in the second case below.