[webkit-reviews] review granted: [Bug 208784] REGRESSION (r258064): API tests intermittently crashing under WebKit::registerDefaultsOverride : [Attachment 392976] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 208784: REGRESSION (r258064): API tests intermittently crashing under
WebKit::registerDefaultsOverride
https://bugs.webkit.org/show_bug.cgi?id=208784

Attachment 392976: Patch

https://bugs.webkit.org/attachment.cgi?id=392976&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 392976
  --> https://bugs.webkit.org/attachment.cgi?id=392976
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392976&action=review

> Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm:107
>      registerDefaultsOriginal =
method_setImplementation(registerDefaultsMethod,
(IMP)registerDefaultsOverride);

Is this early enough? Seems like there is a race here if registerDefaults is
being called on another thread. Doing it on the main thread is good, but also
it needs to be really early, before other threads exist.