[webkit-reviews] review granted: [Bug 208787] Build Fix : [Attachment 392973] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 8 12:41:40 PDT 2020


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 208787: Build Fix
https://bugs.webkit.org/show_bug.cgi?id=208787

Attachment 392973: Patch

https://bugs.webkit.org/attachment.cgi?id=392973&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 392973
  --> https://bugs.webkit.org/attachment.cgi?id=392973
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392973&action=review

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:719
> -#if USE(UICONTEXTMENU)
> +#if USE(UICONTEXTMENU) && HAVE(LINK_PREVIEW)

Pretty sure you want ENABLE(DATA_DETECTION) instead of HAVE(LINK_PREVIEW)


More information about the webkit-reviews mailing list