[webkit-reviews] review granted: [Bug 208777] Create a flag to disable in-app browser quirks : [Attachment 392934] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 208777: Create a flag to disable in-app browser quirks
https://bugs.webkit.org/show_bug.cgi?id=208777

Attachment 392934: Patch

https://bugs.webkit.org/attachment.cgi?id=392934&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 392934
  --> https://bugs.webkit.org/attachment.cgi?id=392934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392934&action=review

> Source/WebKit/FeatureFlags/WebKit.plist:44
> +	<key>NeedsInAppBrowserPrivacyQuirks</key>
> +	<dict>
> +		<key>Enabled</key>
> +		<true/>
> +	</dict>

Remove.

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:223
> +bool defaultNeedsInAppBrowserPrivacyQuirks()
> +{
> +#if HAVE(HAVE_SYSTEM_FEATURE_FLAGS)
> +    return os_feature_enabled(WebKit, NeedsInAppBrowserPrivacyQuirks);
> +#else
>      return false;
> +#endif
>  }

Remove.