[webkit-reviews] review denied: [Bug 208777] Create a flag to disable AppBound quirks : [Attachment 392915] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 208777: Create a flag to disable AppBound quirks
https://bugs.webkit.org/show_bug.cgi?id=208777

Attachment 392915: Patch

https://bugs.webkit.org/attachment.cgi?id=392915&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 392915
  --> https://bugs.webkit.org/attachment.cgi?id=392915
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392915&action=review

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:220
> +#endif

#else

Otherwise we have unreachable code.

> Source/WebKit/Shared/WebProcessCreationParameters.h:128
> +    bool needsInAppBrowserPrivacyQuirks { false };

Let's put this on the WebPageCreationParameters instead.
Also, it needs to be serialized somewhere.

> Source/WebKit/WebProcess/WebProcess.cpp:475
> +   
WebCore::RuntimeEnabledFeatures::sharedFeatures().setNeedsInAppBrowserPrivacyQu
irks(parameters.needsInAppBrowserPrivacyQuirks);

Instead of using RuntimeEnabledFeatures, let's just put a bool on WebPage.